qemu-virt64-aarch64/qemu-virt64-riscv支持SDL2 #8130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #include "drivers/lcd.h" | ||
| #include <dfs_file.h> | ||
|
|
||
| #ifdef RT_USING_VIRTIO_GPU |
There was a problem hiding this comment.
您的意思是将前面的这些头文件加到virtio gpu那边，还是比如将整个代码集成到virtio.c文件里面
There was a problem hiding this comment.
我重新修改一下，把drv_fb.c合并到virtio.c里面
zhkag
reviewed
Oct 14, 2023
| */ | ||
|
|
||
| #include <ioremap.h> | ||
| #include <lwp_user_mm.h> |
components/drivers/virtio/virtio.h
Outdated
| @@ -18,6 +18,7 @@ | |||
| #ifdef RT_USING_SMART | |||
| #include <mmu.h> | |||
| #include <ioremap.h> | |||
| #include <lwp_user_mm.h> | |||
There was a problem hiding this comment.
我修改一下，这里欠缺考虑，我之前想着virtio.c会包含virtio.h，所以直接在virtio.h里面添加了，virtio.c用到确实应该在virtio.c中来包含这个头文件
| @@ -221,8 +221,4 @@ int graphic_init(void) | |||
|
|
|||
| return -RT_ERROR; | |||
| } | |||
| #ifdef RT_USING_SMP | |||
| INIT_ENV_EXPORT(graphic_init); | |||
| #else | |||
| MSH_CMD_EXPORT(graphic_init, Graphic initialize); | |||
There was a problem hiding this comment.
graphic.c是virtio_GPU的demo，之前就有了，我把这个代码的自启动去掉，因为会与我写的代码冲突，我这边将这个名字重新修改一下
BernardXiong
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
qemu-virt64-aarch64/qemu-virt64-riscv支持SDL2
你的解决方案是什么 (what is your solution)
增加framebuffer device
在什么测试环境下测试通过 (what is the test environment)
qemu-virt64-aarch64
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up